Re: [PATCH v2] arm64: dts: ipq5018: Correct uart1_pins pinconf

From: Bryan O'Donoghue
Date: Fri Sep 01 2023 - 10:31:47 EST


On 01/09/2023 14:09, Ziyang Huang wrote:
Is this change something that should be expressed for a particular board ?


Yes, this is device-special. Some boards use GPIO20 and 21 while others use GPIO28 and 29. But we have defined a wrong value here. At lease, it should be a correct demo. Or should I leave 2 configs here to let device choose?

https://gist.github.com/ptpt52/ae47eb7b86ce2911df06d067152f02ac

U-Boot 2016.01 (Jul 08 2021 - 07:14:42 +0000)

DRAM: smem ram ptable found: ver: 1 len: 4
256 MiB
TEST-
SPI_ADDR_LEN=3
SF: Detected XM25QU128C with page size 256 Bytes, erase size 4 KiB, total 16 MiB
*** Warning - bad CRC, using default environment

In: serial@78AF000
Out: serial@78AF000
Err: serial@78AF000

So, we're saying the correct default console is blsp0_uart0 ?

https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/blob/5343739b4070bcec2fecd72f758c16adc31a3083/arch/arm/dts/ipq5018-mp03.3.dts

---
bod