Re: [PATCH v8 5/8] x86/resctrl: Unwind the errors inside rdt_enable_ctx()

From: Fenghua Yu
Date: Fri Sep 01 2023 - 19:33:59 EST




On 8/21/23 16:30, Babu Moger wrote:
rdt_enable_ctx() enables the features provided during resctrl mount.

Additions to rdt_enable_ctx() are required to also modify error paths
of rdt_enable_ctx() callers to ensure correct unwinding if errors
are encountered after calling rdt_enable_ctx(). This is error prone.

Introduce rdt_disable_ctx() to refactor the error unwinding of
rdt_enable_ctx() to simplify future additions. This also simplifies
cleanup in rdt_kill_sb().

Remove cdp_disable_all() as it is not used anymore after the refactor.

Suggested-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
Signed-off-by: Babu Moger <babu.moger@xxxxxxx>

Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>

Thanks.

-Fenghua