Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ8174 family

From: Dmitry Baryshkov
Date: Sat Sep 02 2023 - 11:38:30 EST


On Sat, 2 Sept 2023 at 17:43, Kathiravan T <quic_kathirav@xxxxxxxxxxx> wrote:
>
>
> On 9/1/2023 11:40 PM, Robert Marko wrote:
> > IPQ8174 (Oak) family is part of the IPQ8074 family, but the ID-s for it
> > are missing so lets add them.
> >
> > Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> > ---
> > include/dt-bindings/arm/qcom,ids.h | 3 +++
> > 1 file changed, 3 insertions(+)
>
>
> Reviewed-by: Kathiravan T <quic_kathirav@xxxxxxxxxxx>

Is there a chance of you using the full family name in your git tags?

> > diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> > index be12e1dd1f38..d2b84a308fde 100644
> > --- a/include/dt-bindings/arm/qcom,ids.h
> > +++ b/include/dt-bindings/arm/qcom,ids.h
> > @@ -203,6 +203,9 @@
> > #define QCOM_ID_SM6125 394
> > #define QCOM_ID_IPQ8070A 395
> > #define QCOM_ID_IPQ8071A 396
> > +#define QCOM_ID_IPQ8172 397
> > +#define QCOM_ID_IPQ8173 398
> > +#define QCOM_ID_IPQ8174 399
> > #define QCOM_ID_IPQ6018 402
> > #define QCOM_ID_IPQ6028 403
> > #define QCOM_ID_SDM429W 416



--
With best wishes
Dmitry