Re: [PATCH 8/8] i2c: sprd: Increase the waiting time for IIC transmission to avoid system crash issues

[Andi Shyti]

Hi Huangzheng,

On Thu, Aug 17, 2023 at 05:45:20PM +0800, Huangzheng Lai wrote:
> Due to the relatively low priority of the isr_thread, when the CPU
> load is high, the execution of sprd_i2c_isr_thread will be delayed.
> After the waiting time is exceeded, the IIC driver will perform
> operations such as disabling the IIC controller. Later, when
> sprd_i2c_isr_thread is called by the CPU, there will be kernel panic
> caused by illegal access to the IIC register. After pressure testing,
> we found that increasing the IIC waiting time to 10 seconds can
> avoid this problem.
> 
> Signed-off-by: Huangzheng Lai <Huangzheng.Lai@xxxxxxxxxx>

Is this a fix? Then please consider adding:

0b884fe71f9e ("i2c: sprd: use a specific timeout to avoid system hang up issue")
Cc: <stable@xxxxxxxxxxxxxxx> # v5.11+

Andi

> ---
>  drivers/i2c/busses/i2c-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
> index 6f65f28ea69d..3c7af04fa177 100644
> --- a/drivers/i2c/busses/i2c-sprd.c
> +++ b/drivers/i2c/busses/i2c-sprd.c
> @@ -76,7 +76,7 @@
>  /* timeout (ms) for pm runtime autosuspend */
>  #define SPRD_I2C_PM_TIMEOUT	1000
>  /* timeout (ms) for transfer message */
> -#define I2C_XFER_TIMEOUT	1000
> +#define I2C_XFER_TIMEOUT	10000
>  /* dynamic modify clk_freq flag  */
>  #define	I2C_3M4_FLAG		0x0100
>  #define	I2C_1M_FLAG		0x0080
> -- 
> 2.17.1
>