Re: [PATCH 2/2] JBD2: fix printk format type for 'io_block' in do_one_pass()

From: Jan Kara
Date: Mon Sep 04 2023 - 04:46:42 EST


On Mon 04-09-23 09:10:21, Ye Bin wrote:
> 'io_block' is unsinged long but print it by '%ld'.
>
> Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> fs/jbd2/recovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
> index a2e2bdaed9f8..d10dc7f64301 100644
> --- a/fs/jbd2/recovery.c
> +++ b/fs/jbd2/recovery.c
> @@ -632,7 +632,7 @@ static int do_one_pass(journal_t *journal,
> success = err;
> printk(KERN_ERR
> "JBD2: IO error %d recovering "
> - "block %ld in log\n",
> + "block %lu in log\n",
> err, io_block);
> } else {
> unsigned long long blocknr;
> --
> 2.31.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR