Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()

From: Andy Shevchenko
Date: Mon Sep 04 2023 - 05:12:15 EST


On Sat, Sep 02, 2023 at 10:09:37AM +0100, Biju Das wrote:
> Add struct mcp23s08_i2c_info and simplify probe() by replacing
> match data 'type' with 'struct mcp23s08_i2c_info'.
>
> While at it, replace dev_err()->dev_err_probe().

'->' --> ' --> '

...

> + info = i2c_get_match_data(client);
> + if (!info)
> + return dev_err_probe(dev, -EINVAL, "invalid device type (%d)\n",

> + info->type);

Huh?! Please, think about it...

--
With Best Regards,
Andy Shevchenko