Re: [PATCH 2/2] power: supply: bq2515x: Some cleanups

From: Andy Shevchenko
Date: Mon Sep 04 2023 - 06:19:23 EST


On Mon, Sep 04, 2023 at 01:10:04PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 02, 2023 at 09:05:18PM +0100, Biju Das wrote:
> > Some cleanups:
> > * Remove trailing comma in the terminator entry for OF/ID table.
> > * Drop a space from terminator entry for OF table.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Btw, in all similar patches you may add the reason(s) why you are doing that:
>
> 1/ unification;
> 2/ making code robust against (theoretical) misrebases or other similar things
> where the new entry goes _after_ the termination without compiler noticing.

I.o.w. "terminator" has to "terminate" at run-time _and_ at compile-time.

--
With Best Regards,
Andy Shevchenko