RE: [PATCH 2/2] i2c: I2C_MLXCPLD on ARM64 should depend on ACPI

[Vadim Pasternak]

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: Monday, 4 September 2023 15:01
> To: Andi Shyti <andi.shyti@xxxxxxxxxx>; Hans de Goede <hdegoede@xxxxxxxxxx>;
> Mark Gross <markgross@xxxxxxxxxx>; Vadim Pasternak <vadimp@xxxxxxxxxx>;
> Michael Shych <michaelsh@xxxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Subject: [PATCH 2/2] i2c: I2C_MLXCPLD on ARM64 should depend on ACPI
> 
> The "i2c_mlxcpld" platform device is only instantiated on X86 systems (through
> drivers/platform/x86/mlx-platform.c), or on ARM64 systems with ACPI (through
> drivers/platform/mellanox/nvsw-sn2201.c).  Hence further restrict the dependency
> on ARM64 to ACPI, to prevent asking the user about this driver when configuring
> an ARM64 kernel without ACPI support.
> 
> While at it, document in the Kconfig help text that the driver supports
> ARM64/ACPI based systems, too.
> 
> Fixes: d7cf993f832ad2a4 ("i2c: mlxcpld: Allow driver to run on ARM64
> architecture")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Acked-by: Vadim Pasternak <vadimp@xxxxxxxxxx>

> ---
>  drivers/i2c/busses/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index
> 0aa97762332d8a87..bef2af50fb159baf 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1391,10 +1391,10 @@ config I2C_ICY
> 
>  config I2C_MLXCPLD
>  	tristate "Mellanox I2C driver"
> -	depends on X86_64 || ARM64 || COMPILE_TEST
> +	depends on X86_64 || (ARM64 && ACPI) || COMPILE_TEST
>  	help
>  	  This exposes the Mellanox platform I2C busses to the linux I2C layer
> -	  for X86 based systems.
> +	  for X86 and ARM64/ACPI based systems.
>  	  Controller is implemented as CPLD logic.
> 
>  	  This driver can also be built as a module. If so, the module will be
> --
> 2.34.1