Re: [PATCH v5 1/2] dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible

[Lee Jones]

On Sat, 02 Sep 2023, Conor Dooley wrote:

> On Fri, Sep 01, 2023 at 03:18:55PM +0100, Sean Young wrote:
> > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
> > can be removed.
> > 
> > Signed-off-by: Sean Young <sean@xxxxxxxx>
> 
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> > ---
> >  .../bindings/leds/irled/pwm-ir-tx.yaml        |  5 ++++-

Acked-by: Lee Jones <lee@xxxxxxxxxx>

> >  .../devicetree/bindings/media/nokia,n900-ir   | 20 -------------------
> >  2 files changed, 4 insertions(+), 21 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml
> > index f2a6fa140f38..7526e3149f72 100644
> > --- a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml
> > @@ -15,7 +15,10 @@ description:
> >  
> >  properties:
> >    compatible:
> > -    const: pwm-ir-tx
> > +    oneOf:
> > +      - const: pwm-ir-tx
> > +      - const: nokia,n900-ir
> > +        deprecated: true
> >  
> >    pwms:
> >      maxItems: 1
> > diff --git a/Documentation/devicetree/bindings/media/nokia,n900-ir b/Documentation/devicetree/bindings/media/nokia,n900-ir
> > deleted file mode 100644
> > index 13a18ce37dd1..000000000000
> > --- a/Documentation/devicetree/bindings/media/nokia,n900-ir
> > +++ /dev/null
> > @@ -1,20 +0,0 @@
> > -Device-Tree bindings for LIRC TX driver for Nokia N900(RX51)
> > -
> > -Required properties:
> > -	- compatible: should be "nokia,n900-ir".
> > -	- pwms: specifies PWM used for IR signal transmission.
> > -
> > -Example node:
> > -
> > -	pwm9: dmtimer-pwm@9 {
> > -		compatible = "ti,omap-dmtimer-pwm";
> > -		ti,timers = <&timer9>;
> > -		ti,clock-source = <0x00>; /* timer_sys_ck */
> > -		#pwm-cells = <3>;
> > -	};
> > -
> > -	ir: n900-ir {
> > -		compatible = "nokia,n900-ir";
> > -
> > -		pwms = <&pwm9 0 26316 0>; /* 38000 Hz */
> > -	};
> > -- 
> > 2.42.0
> > 



-- 
Lee Jones [李琼斯]