Re: [PATCH] cxl/mbox: Fix CEL logic for poison and security commands

[Davidlohr Bueso]

On Sun, 03 Sep 2023, Ira Weiny wrote:

> The following debug output was observed while testing CXL
>
> cxl_core:cxl_walk_cel:721: cxl_mock_mem cxl_mem.0: Opcode 0x4300 unsupported by driver
>
> opcode 0x4300 (Get Poison) is supported by the driver and the mock
> device supports it.  The logic should be checking that the opcode is
> both not poison and not security.
>
> Fix the logic to allow poison and security commands.

Hmm yeah sorry about that.

Reviewed-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>

> Fixes: ad64f5952ce3 ("cxl/memdev: Only show sanitize sysfs files when supported")
> Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> ---
> drivers/cxl/core/mbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index ca60bb8114f2..b315bdab9197 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -716,8 +716,8 @@ static void cxl_walk_cel(struct cxl_memdev_state *mds, size_t size, u8 *cel)
> 		u16 opcode = le16_to_cpu(cel_entry[i].opcode);
> 		struct cxl_mem_command *cmd = cxl_mem_find_command(opcode);
>
> -		if (!cmd && (!cxl_is_poison_command(opcode) ||
> -			     !cxl_is_security_command(opcode))) {
> +		if (!cmd && !cxl_is_poison_command(opcode) &&
> +		    !cxl_is_security_command(opcode)) {
> 			dev_dbg(dev,
> 				"Opcode 0x%04x unsupported by driver\n", opcode);
> 			continue;
>
> ---
> base-commit: 1c59d383390f970b891b503b7f79b63a02db2ec5
> change-id: 20230903-cxl-cel-fix-9da269bf0f21
>
> Best regards,
> --
> Ira Weiny <ira.weiny@xxxxxxxxx>