Re: [PATCH V1 3/3] ASoC: codecs: Add aw87390 amplifier driver

[Linus Walleij]

Hi Weidong,

thanks for your patch!

On Mon, Sep 4, 2023 at 1:47 PM <wangweidong.a@xxxxxxxxxx> wrote:

> From: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>
> Add i2c and amplifier registration for aw87390 and
> their associated operation functions.
>
> Signed-off-by: Weidong Wang <wangweidong.a@xxxxxxxxxx>
(...)
> +#include <linux/of_gpio.h>

Please do not include this deprecated header.

Also: it seems you do not even use it so it's unnecessary.

Yours,
Linus Walleij