Re: [PATCH v2 0/2] Fix tps65217-charger vs vbus irq conflict

From: Tony Lindgren
Date: Tue Sep 05 2023 - 12:03:37 EST


* Grant B Adams <nemith592@xxxxxxxxx> [230823 08:54]:
> Both the tps65217-charger and vbus drivers are trying to allocate the same
> TPS65217 device interrupt line (TPS65217 is a TI power management IC)
> which results in the following error and a probe failure:
>
> genirq: Flags mismatch irq 148. 00002000 (vbus) vs. 00000000
> (tps65217-charger)
>
> For the Beaglebone Black's config the tps65217-charger driver is currently
> disabled and therefore no conflict. Based on comments from Robert C Nelson
> this driver has been disabled for a long time and he is uncertain on the
> reasons why it was disabled. With a battery connected to the BBB, I
> re-enabled the tps65217-charger driver which resulted in the
> abovementioned.
>
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.

Looks good to me:

Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx>