Re: [PATCH v16 07/20] drm/shmem-helper: Make all exported symbols GPL

From: Boris Brezillon
Date: Tue Sep 05 2023 - 12:20:03 EST


On Sun, 3 Sep 2023 20:07:23 +0300
Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> wrote:

> Make all drm-shmem exported symbols GPL to make them consistent with
> the rest of drm-shmem symbols.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 848435e08eb2..5c777adf1bcb 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -228,7 +228,7 @@ void drm_gem_shmem_put_pages(struct drm_gem_shmem_object *shmem)
> shmem->pages_mark_accessed_on_put);
> shmem->pages = NULL;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_put_pages);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_put_pages);
>
> static int drm_gem_shmem_pin_locked(struct drm_gem_shmem_object *shmem)
> {
> @@ -273,7 +273,7 @@ int drm_gem_shmem_pin(struct drm_gem_shmem_object *shmem)
>
> return ret;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_pin);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_pin);
>
> /**
> * drm_gem_shmem_unpin - Unpin backing pages for a shmem GEM object
> @@ -292,7 +292,7 @@ void drm_gem_shmem_unpin(struct drm_gem_shmem_object *shmem)
> drm_gem_shmem_unpin_locked(shmem);
> dma_resv_unlock(shmem->base.resv);
> }
> -EXPORT_SYMBOL(drm_gem_shmem_unpin);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_unpin);
>
> /*
> * drm_gem_shmem_vmap - Create a virtual mapping for a shmem GEM object
> @@ -362,7 +362,7 @@ int drm_gem_shmem_vmap(struct drm_gem_shmem_object *shmem,
>
> return ret;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_vmap);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_vmap);
>
> /*
> * drm_gem_shmem_vunmap - Unmap a virtual mapping for a shmem GEM object
> @@ -398,7 +398,7 @@ void drm_gem_shmem_vunmap(struct drm_gem_shmem_object *shmem,
>
> shmem->vaddr = NULL;
> }
> -EXPORT_SYMBOL(drm_gem_shmem_vunmap);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_vunmap);
>
> static int
> drm_gem_shmem_create_with_handle(struct drm_file *file_priv,
> @@ -437,7 +437,7 @@ int drm_gem_shmem_madvise(struct drm_gem_shmem_object *shmem, int madv)
>
> return (madv >= 0);
> }
> -EXPORT_SYMBOL(drm_gem_shmem_madvise);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_madvise);
>
> void drm_gem_shmem_purge(struct drm_gem_shmem_object *shmem)
> {
> @@ -469,7 +469,7 @@ void drm_gem_shmem_purge(struct drm_gem_shmem_object *shmem)
>
> invalidate_mapping_pages(file_inode(obj->filp)->i_mapping, 0, (loff_t)-1);
> }
> -EXPORT_SYMBOL(drm_gem_shmem_purge);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_purge);
>
> /**
> * drm_gem_shmem_dumb_create - Create a dumb shmem buffer object
> @@ -644,7 +644,7 @@ void drm_gem_shmem_print_info(const struct drm_gem_shmem_object *shmem,
> drm_printf_indent(p, indent, "vmap_use_count=%u\n", shmem->vmap_use_count);
> drm_printf_indent(p, indent, "vaddr=%p\n", shmem->vaddr);
> }
> -EXPORT_SYMBOL(drm_gem_shmem_print_info);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_print_info);
>
> /**
> * drm_gem_shmem_get_sg_table - Provide a scatter/gather table of pinned