Re: [PATCH] Revert "printk: export symbols for debug modules"

From: Christoph Hellwig
Date: Tue Sep 05 2023 - 12:20:05 EST


On Tue, Sep 05, 2023 at 11:54:37AM +0200, Petr Mladek wrote:
> Yeah, I did not have a good feeling about this patch.
>
> I accepted it because there was an intention to upstream
> the module, see
> https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@xxxxxxxxxxxxxx/
>
> I think that it was bad decision. We should not export
> symbols when there is no in-tree user.

I think raw address to the printk buffer is a bad idea even for an
in-tree module.