Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume

From: Dan Carpenter
Date: Tue Sep 05 2023 - 12:42:09 EST


On Tue, Sep 05, 2023 at 09:35:56AM +0800, Dongliang Mu wrote:
> In ath9k_hif_usb_resume, the error handling code calls
> ath9k_hif_usb_dealloc_urbs twice in different paths.
>
> To unify the error handling code, we move the else branch before
> the if branch and drop one level of indentation of the if branch.
>
> In addition, move the ret variable at the end of variable declarations
> to be reverse x-mas tree order.
>
> Note that this patch does not incur any functionability change.
>
> Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath9k/hif_usb.c | 34 ++++++++++++------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> v1->v2: move the else branch on top of if branch;
> move ret variable at the end of variable declarations;

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter