Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config

From: Lad, Prabhakar
Date: Tue Sep 05 2023 - 12:52:12 EST


Hi Conor,

On Sat, Sep 2, 2023 at 12:02 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Fri, Sep 01, 2023 at 12:03:20PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> > enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> > avoid any build failures.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@xxxxxxxxx/
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Replied here earlier, but pressed the wrong key & it only went to the
> list.
> I think this patch probably also needs to grow a Fixes tag, for
> commit f2863f30d1b0 ("riscv: errata: Add Andes alternative ports").
>
> The 4 Kconfig patches ideally would've been in a series, since 3 of the
> 4 seem to be fixes & the 4th depends on one of the fixes being applied.
>
My bad I should i've posted them as a series.

Cheers,
Prabhakar