Re: [PATCH] tracing: Fix unexpected ring buffer expand by instance
From: kernel test robot
Date: Tue Sep 05 2023 - 15:40:27 EST
Hi Zheng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.5 next-20230905]
[cannot apply to rostedt-trace/for-next rostedt-trace/for-next-urgent]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zheng-Yejian/tracing-Fix-unexpected-ring-buffer-expand-by-instance/20230906-014353
base: linus/master
patch link: https://lore.kernel.org/r/20230905121714.3229131-1-zhengyejian1%40huawei.com
patch subject: [PATCH] tracing: Fix unexpected ring buffer expand by instance
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230906/202309060320.psgXz5VD-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309060320.psgXz5VD-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309060320.psgXz5VD-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> kernel/trace/trace.c:6438: warning: Function parameter or member 'tr' not described in 'tracing_update_buffers'
vim +6438 kernel/trace/trace.c
4f271a2a60c748 Vaibhav Nagarnaik 2011-06-13 6425
ef710e100c1068 KOSAKI Motohiro 2010-07-01 6426
1852fcce181faa Steven Rostedt 2009-03-11 6427 /**
1852fcce181faa Steven Rostedt 2009-03-11 6428 * tracing_update_buffers - used by tracing facility to expand ring buffers
1852fcce181faa Steven Rostedt 2009-03-11 6429 *
1852fcce181faa Steven Rostedt 2009-03-11 6430 * To save on memory when the tracing is never used on a system with it
1852fcce181faa Steven Rostedt 2009-03-11 6431 * configured in. The ring buffers are set to a minimum size. But once
1852fcce181faa Steven Rostedt 2009-03-11 6432 * a user starts to use the tracing facility, then they need to grow
1852fcce181faa Steven Rostedt 2009-03-11 6433 * to their default size.
1852fcce181faa Steven Rostedt 2009-03-11 6434 *
1852fcce181faa Steven Rostedt 2009-03-11 6435 * This function is to be called when a tracer is about to be used.
1852fcce181faa Steven Rostedt 2009-03-11 6436 */
625c101cac2477 Zheng Yejian 2023-09-05 6437 int tracing_update_buffers(struct trace_array *tr)
1852fcce181faa Steven Rostedt 2009-03-11 @6438 {
1852fcce181faa Steven Rostedt 2009-03-11 6439 int ret = 0;
1852fcce181faa Steven Rostedt 2009-03-11 6440
1027fcb206a0fb Steven Rostedt 2009-03-12 6441 mutex_lock(&trace_types_lock);
625c101cac2477 Zheng Yejian 2023-09-05 6442 if (!tr->ring_buffer_expanded)
625c101cac2477 Zheng Yejian 2023-09-05 6443 ret = __tracing_resize_ring_buffer(tr, trace_buf_size,
438ced1720b584 Vaibhav Nagarnaik 2012-02-02 6444 RING_BUFFER_ALL_CPUS);
1027fcb206a0fb Steven Rostedt 2009-03-12 6445 mutex_unlock(&trace_types_lock);
1852fcce181faa Steven Rostedt 2009-03-11 6446
1852fcce181faa Steven Rostedt 2009-03-11 6447 return ret;
1852fcce181faa Steven Rostedt 2009-03-11 6448 }
1852fcce181faa Steven Rostedt 2009-03-11 6449
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki