Re: [PATCH 1/2] dt-bindings: interrupt-controller: arm,gic-v3: Add dma-noncoherent property

From: Rob Herring
Date: Tue Sep 05 2023 - 16:09:00 EST


On Tue, Sep 05, 2023 at 12:47:20PM +0200, Lorenzo Pieralisi wrote:
> The GIC v3 specifications allow redistributors and ITSes interconnect
> ports used to access memory to be wired up in a way that makes the
> respective initiators/memory observers non-coherent.
>
> Add the standard dma-noncoherent property to the GICv3 bindings to
> allow firmware to describe the redistributors/ITSes components and
> interconnect ports behaviour in system designs where the redistributors
> and ITSes are not coherent with the CPU.
>
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../bindings/interrupt-controller/arm,gic-v3.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
> index 39e64c7f6360..0a81ae4519a6 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
> @@ -106,6 +106,10 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> maximum: 4096
>
> + dma-noncoherent:
> + description: |

Don't need the '|' if no formatting to preserve.

> + Present if the GIC redistributors are not cache coherent with the CPU.
> +
> msi-controller:
> description:
> Only present if the Message Based Interrupt functionality is
> @@ -193,6 +197,10 @@ patternProperties:
> compatible:
> const: arm,gic-v3-its
>
> + dma-noncoherent:
> + description: |
> + Present if the GIC ITS is not cache coherent with the CPU.
> +
> msi-controller: true
>
> "#msi-cells":
> --
> 2.34.1
>