Re: [PATCH 2/7] poll: Add a poll_flags for poll_queue_proc()
From: kernel test robot
Date: Tue Sep 05 2023 - 19:22:36 EST
Hi Peter,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-userfaultfd-Make-uffd-read-wait-event-exclusive/20230906-054430
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230905214235.320571-3-peterx%40redhat.com
patch subject: [PATCH 2/7] poll: Add a poll_flags for poll_queue_proc()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230906/202309060752.FQUjUmGA-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309060752.FQUjUmGA-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309060752.FQUjUmGA-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> net/9p/trans_fd.c:555: warning: Function parameter or member 'flags' not described in 'p9_pollwait'
vim +555 net/9p/trans_fd.c
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 542
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 543 /**
5503ac565998837 Eric Van Hensbergen 2008-10-13 544 * p9_pollwait - add poll task to the wait queue
5503ac565998837 Eric Van Hensbergen 2008-10-13 545 * @filp: file pointer being polled
5503ac565998837 Eric Van Hensbergen 2008-10-13 546 * @wait_address: wait_q to block on
5503ac565998837 Eric Van Hensbergen 2008-10-13 547 * @p: poll state
ee443996a35c1e0 Eric Van Hensbergen 2008-03-05 548 *
5503ac565998837 Eric Van Hensbergen 2008-10-13 549 * called by files poll operation to add v9fs-poll task to files wait queue
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 550 */
ee443996a35c1e0 Eric Van Hensbergen 2008-03-05 551
5503ac565998837 Eric Van Hensbergen 2008-10-13 552 static void
14649d7d7806aba Peter Xu 2023-09-05 553 p9_pollwait(struct file *filp, wait_queue_head_t *wait_address, poll_table *p,
14649d7d7806aba Peter Xu 2023-09-05 554 poll_flags flags)
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 @555 {
5503ac565998837 Eric Van Hensbergen 2008-10-13 556 struct p9_conn *m = container_of(p, struct p9_conn, pt);
5503ac565998837 Eric Van Hensbergen 2008-10-13 557 struct p9_poll_wait *pwait = NULL;
5503ac565998837 Eric Van Hensbergen 2008-10-13 558 int i;
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 559
5503ac565998837 Eric Van Hensbergen 2008-10-13 560 for (i = 0; i < ARRAY_SIZE(m->poll_wait); i++) {
5503ac565998837 Eric Van Hensbergen 2008-10-13 561 if (m->poll_wait[i].wait_addr == NULL) {
5503ac565998837 Eric Van Hensbergen 2008-10-13 562 pwait = &m->poll_wait[i];
5503ac565998837 Eric Van Hensbergen 2008-10-13 563 break;
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 564 }
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 565 }
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 566
5503ac565998837 Eric Van Hensbergen 2008-10-13 567 if (!pwait) {
5d3851530d6d685 Joe Perches 2011-11-28 568 p9_debug(P9_DEBUG_ERROR, "not enough wait_address slots\n");
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 569 return;
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 570 }
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 571
5503ac565998837 Eric Van Hensbergen 2008-10-13 572 pwait->conn = m;
5503ac565998837 Eric Van Hensbergen 2008-10-13 573 pwait->wait_addr = wait_address;
5503ac565998837 Eric Van Hensbergen 2008-10-13 574 init_waitqueue_func_entry(&pwait->wait, p9_pollwake);
5503ac565998837 Eric Van Hensbergen 2008-10-13 575 add_wait_queue(wait_address, &pwait->wait);
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 576 }
8a0dc95fd976a05 Eric Van Hensbergen 2008-02-06 577
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki