Re: [PATCH 6/7] fbdev/core: Remove empty internal helpers from fb_logo.c

From: Javier Martinez Canillas
Date: Wed Sep 06 2023 - 06:14:12 EST


Thomas Zimmermann <tzimmermann@xxxxxxx> writes:

> Remove the two empty helpers for the case the CONFIG_FB_LOGO_EXTRA
> has not been set. They are internal functions and only called once.
> Providing empty replacements seems like overkill. Instead protect
> the call sites with a test for CONFIG_FB_LOGO_EXTRA.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---

Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat