Re: [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro

From: Ilpo Järvinen
Date: Wed Sep 06 2023 - 06:47:23 EST


On Tue, 5 Sep 2023, Hugo Villeneuve wrote:

> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> This macro is not used anywhere.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> ---
> drivers/tty/serial/sc16is7xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index f61d98e09dc3..d8534580c6d5 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -358,7 +358,6 @@ static struct uart_driver sc16is7xx_uart = {
> static void sc16is7xx_ier_set(struct uart_port *port, u8 bit);
> static void sc16is7xx_stop_tx(struct uart_port *port);
>
> -#define to_sc16is7xx_port(p,e) ((container_of((p), struct sc16is7xx_port, e)))
> #define to_sc16is7xx_one(p,e) ((container_of((p), struct sc16is7xx_one, e)))
>
> static int sc16is7xx_line(struct uart_port *port)
>
> base-commit: 3f86ed6ec0b390c033eae7f9c487a3fea268e027

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Note that Greg might be happier if you wait next time until after the
merge window is closed before sending non-fixes patch like this.

--
i.