Re: [PATCH 1/2] net: ethernet: davinci_emac: Use MAC Address from Device Tree

[Andrew Lunn]

On Wed, Sep 06, 2023 at 04:51:42AM -0500, Adam Ford wrote:
> Currently there is a device tree entry called "local-mac-address"
> which can be filled by the bootloader or manually set.This is
> useful when the user does not want to use the MAC address
> programmed into the SoC.
> 
> Currently, the davinci_emac reads the MAC from the DT, copies
> it from pdata->mac_addr to priv->mac_addr, then blindly overwrites
> it by reading from registers in the SoC, and falls back to a
> random MAC if it's still not valid.  This completely ignores any
> MAC address in the device tree.
> 
> In order to use the local-mac-address, check to see if the contents
> of priv->mac_addr are valid before falling back to reading from the
> SoC when the MAC address is not valid.
> 
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>

There is the potential for regressions here, since behaviour is being
changed. But i do think what you are doing make sense.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew