Re: [PATCH v1] ALSA: hda: cs35l41: Support mute notifications for CS35L41 HDA
From: kernel test robot
Date: Wed Sep 06 2023 - 08:57:16 EST
Hi Stefan,
kernel test robot noticed the following build errors:
[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus linus/master next-20230906]
[cannot apply to v6.5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Binding/ALSA-hda-cs35l41-Support-mute-notifications-for-CS35L41-HDA/20230825-200835
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20230825120525.1337417-1-sbinding%40opensource.cirrus.com
patch subject: [PATCH v1] ALSA: hda: cs35l41: Support mute notifications for CS35L41 HDA
config: arm-defconfig (https://download.01.org/0day-ci/archive/20230906/202309062027.esqlhxcg-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309062027.esqlhxcg-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309062027.esqlhxcg-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
sound/pci/hda/patch_realtek.c: In function 'comp_acpi_device_notify':
>> sound/pci/hda/patch_realtek.c:6717:52: error: implicit declaration of function 'acpi_device_handle'; did you mean 'acpi_fwnode_handle'? [-Werror=implicit-function-declaration]
6717 | spec->comps[i].acpi_notify(acpi_device_handle(spec->comps[i].adev), event,
| ^~~~~~~~~~~~~~~~~~
| acpi_fwnode_handle
sound/pci/hda/patch_realtek.c:6717:52: warning: passing argument 1 of 'spec->comps[i].acpi_notify' makes pointer from integer without a cast [-Wint-conversion]
6717 | spec->comps[i].acpi_notify(acpi_device_handle(spec->comps[i].adev), event,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
sound/pci/hda/patch_realtek.c:6717:52: note: expected 'acpi_handle' {aka 'void *'} but argument is of type 'int'
sound/pci/hda/patch_realtek.c: In function 'comp_bind':
>> sound/pci/hda/patch_realtek.c:6737:47: error: invalid use of undefined type 'struct acpi_device'
6737 | ret = acpi_install_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY,
| ^~
sound/pci/hda/patch_realtek.c: In function 'comp_unbind':
sound/pci/hda/patch_realtek.c:6760:46: error: invalid use of undefined type 'struct acpi_device'
6760 | ret = acpi_remove_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY,
| ^~
cc1: some warnings being treated as errors
vim +6717 sound/pci/hda/patch_realtek.c
6706
6707 static void comp_acpi_device_notify(acpi_handle handle, u32 event, void *data)
6708 {
6709 struct hda_codec *cdc = data;
6710 struct alc_spec *spec = cdc->spec;
6711 int i;
6712
6713 codec_info(cdc, "ACPI Notification %d\n", event);
6714
6715 for (i = 0; i < HDA_MAX_COMPONENTS; i++) {
6716 if (spec->comps[i].dev && spec->comps[i].acpi_notify)
> 6717 spec->comps[i].acpi_notify(acpi_device_handle(spec->comps[i].adev), event,
6718 spec->comps[i].dev);
6719 }
6720 }
6721
6722 static int comp_bind(struct device *dev)
6723 {
6724 struct hda_codec *cdc = dev_to_hda_codec(dev);
6725 struct alc_spec *spec = cdc->spec;
6726 struct acpi_device *adev;
6727 int ret;
6728
6729 ret = component_bind_all(dev, spec->comps);
6730 if (ret)
6731 return ret;
6732
6733 adev = spec->comps[0].adev;
6734 if (!acpi_device_handle(adev))
6735 return 0;
6736
> 6737 ret = acpi_install_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY,
6738 comp_acpi_device_notify, cdc);
6739 if (ret < 0) {
6740 codec_warn(cdc, "Failed to install notify handler: %d\n", ret);
6741 return 0;
6742 }
6743
6744 codec_dbg(cdc, "Notify handler installed\n");
6745
6746 return 0;
6747 }
6748
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki