Re: [PATCH v5 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R

[Alexandre Belloni]

On 06/09/2023 09:19:29+0800, Mining Lin wrote:
> >> static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >> {
> >>    int err, flags;
> >> @@ -55,7 +59,7 @@ static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >>    flags =  i2c_smbus_read_byte_data(client, NCT3018Y_REG_CTRL);
> >>    if (flags < 0) {
> >>        dev_dbg(&client->dev,
> >> -            "Failed to read NCT3018Y_REG_CTRL\n");
> >> +            "%s: Failed to read ctrl reg.\n", __func__);
> > 
> > If you really insist on this change, what about:
> > 
> > #define pr_fmt(fmt) "%s: " fmt, __func__
> [Mia] Do you mean to replace dev_dbg with pr_debug? If yes, for consistency, I'm going to refine all messages via pr_debug. Thank you for your suggestion.

No, I mean that instead of adding __func__ to all the messages just
define pr_fmt, this should achieve what you want.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com