Re: [PATCH v2 4/4] arm64: dts: qcom: sc7180: Add ADSP

From: Konrad Dybcio
Date: Wed Sep 06 2023 - 10:54:19 EST


On 6.09.2023 16:52, Nikita Travkin wrote:
> Krzysztof Kozlowski писал(а) 06.09.2023 18:36:
>> On 05/09/2023 12:41, Nikita Travkin wrote:
>>> sc7180 has an ADSP remoteproc that exclusively controls the audio
>>> hardware on devices that use Qualcomm firmware.
>>
>>
>>> + q6afe: service@4 {
>>> + compatible = "qcom,q6afe";
>>> + reg = <APR_SVC_AFE>;
>>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>>> +
>>> + q6afedai: dais {
>>> + compatible = "qcom,q6afe-dais";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + #sound-dai-cells = <1>;
>>> + };
>>> +
>>> + q6afecc: cc {
>>
>>
>> No improvements.
>>
>> You need to add ADSP to your board and then test it. Otherwise you won't
>> see errors and we do not want incorrect, even if disabled, nodes in DTSI.
>>
>
> Ah, didn't think the check would (partially) ignore disabled nodes...
>
> Is there any simple way to instruct the checker to ignore disabled
> status and test anyway? I'd like to be able to test the "clean"
> series as-to-be-sent to have less places for error (and manual action
> I guess...)
IDK if schema takes any arguments like that, but search-and-replace
status = "disabled" with nothing sounds like it could work

Konrad