Re: [PATCH] sched/fair: Add SMT4 group_smt_balance handling

[Tim Chen]

On Wed, 2023-09-06 at 10:23 +0200, Peter Zijlstra wrote:
> On Tue, Sep 05, 2023 at 10:54:09AM -0700, Tim Chen wrote:
> 
> > > > +		goto fully_busy;
> > > > +		break;
> > > 
> > > This is really daft; why can't this simply be: fallthrough; ? At the
> > > very least that break must go.
> > > 
> > > 
> > 
> > Yes, the break should go.  I was adding the goto to prevent compiler
> > from complaining about fall through code. 
> 
> But that's what we have the fallthrough keyword for, no?

Okay.  Will update patch to use fallthrough once Shrikanth has
a chance to test the update to use has_spare path for SMT4.

Tim