Re: [PATCH] maple_tree: use GFP_KERNEL on mas_node_count

From: Matthew Wilcox
Date: Thu Sep 07 2023 - 00:11:15 EST


On Thu, Sep 07, 2023 at 12:02:02PM +0800, Peng Zhang wrote:
>
>
> 在 2023/9/7 11:49, Matthew Wilcox 写道:
> > On Thu, Sep 07, 2023 at 12:39:14PM +0900, 심재선 wrote:
> > > Use GFP_KERNEL on mas_node_count instead of GFP_NOWAIT | __GFP_NOWARN
> > > in order to allow memory reclaim.
> There are many paths that call maple tree's mas_node_count(). Some paths
> cannot reclaim memory.

Right ... but we should be handling the ENOMEM inside the maple tree and
allocating some nodes with GFP_KERNEL instead of failing fork().

> > What testing did you do of this patch? In particular, did you try it
> > with lockdep enabled?