Re: [PATCH v8 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control

From: Billy Tsai
Date: Thu Sep 07 2023 - 11:26:17 EST


>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/aspeed-clock.h>
>> + pwm_tach: pwm-tach-controller@1e610000 {
>> + compatible = "aspeed,ast2600-pwm-tach";
>> + reg = <0x1e610000 0x100>;
>> + clocks = <&syscon ASPEED_CLK_AHB>;
>> + resets = <&syscon ASPEED_RESET_PWM>;
>> + #pwm-cells = <3>;

> Blank line.

>> + fan0_hwmon {
>> + tach-ch = <0x0>;

> Don't you need 'pwms'?

Yes, I only want to create the fan monitor without fan control.

> + };