[PATCH v3 1/2] arm64: dts: rockchip: use codec as clock master on px30-ringneck-haikou

From: Jakob Unterwurzacher
Date: Thu Sep 07 2023 - 11:28:56 EST


From: Ermin Sunj <ermin.sunj@xxxxxxxxxxxxxxxxxxxxx>

If the codec is not the clock master, the MCLK needs to be
synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that
on Haikou, causing distorted audio.

Before:

Running an audio test script on Ringneck, 1kHz
output sine wave is not stable and shows distortion.

After:

10h audio test script loop failed only one time.
That is 0.00014% failure rate.

Cc: stable@xxxxxxxxxxxxxxx
Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Signed-off-by: Ermin Sunj <ermin.sunj@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@xxxxxxxxxxxxxxxxxxxxx>
---

Notes:
v1: https://lore.kernel.org/lkml/20230823122000.585787-1-jakob.unterwurzacher@xxxxxxxxxxxxxxxxxxxxx/
v2: https://lore.kernel.org/lkml/20230823131651.586934-1-jakob.unterwurzacher@xxxxxxxxxxxxxxxxxxxxx/

arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
index 08a3ad3e7ae9..8792fae50257 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
@@ -68,15 +68,15 @@ i2s0-sound {
simple-audio-card,format = "i2s";
simple-audio-card,name = "Haikou,I2S-codec";
simple-audio-card,mclk-fs = <512>;
+ simple-audio-card,frame-master = <&sgtl5000_codec>;
+ simple-audio-card,bitclock-master = <&sgtl5000_codec>;

- simple-audio-card,codec {
+ sgtl5000_codec: simple-audio-card,codec {
clocks = <&sgtl5000_clk>;
sound-dai = <&sgtl5000>;
};

simple-audio-card,cpu {
- bitclock-master;
- frame-master;
sound-dai = <&i2s0_8ch>;
};
};
--
2.39.2