Re: [PATCH] wifi: mwifiex: Fix oob check condition in mwifiex_process_rx_packet

From: Pin-yen Lin
Date: Thu Sep 07 2023 - 11:31:51 EST


Hi Matthew,

On Thu, Sep 7, 2023 at 5:10 PM Matthew Wang <matthewmwang@xxxxxxxxxxxx> wrote:
>
> > - if ((!memcmp(&rx_pkt_hdr->rfc1042_hdr, bridge_tunnel_header,
> > - sizeof(bridge_tunnel_header))) ||
> > - (!memcmp(&rx_pkt_hdr->rfc1042_hdr, rfc1042_header,
> > - sizeof(rfc1042_header)) &&
> > - ntohs(rx_pkt_hdr->rfc1042_hdr.snap_type) != ETH_P_AARP &&
> > - ntohs(rx_pkt_hdr->rfc1042_hdr.snap_type) != ETH_P_IPX)) {
> > + if (sizeof(rx_pkt_hdr) + rx_pkt_off <= skb->len &&
>
> sizeof(*rx_pkt_hdr)?

Thanks for catching this. I'll upload a v2 for this.

Best,
Pin-yen