Re: [PATCH] vfio/pds: Add missing PCI_IOV depends

From: Jason Gunthorpe
Date: Thu Sep 07 2023 - 12:55:31 EST


On Wed, Sep 06, 2023 at 09:49:42AM +0800, oushixiong wrote:
> From: Shixiong Ou <oushixiong@xxxxxxxxxx>
>
> If PCI_ATS isn't set, then pdev->physfn is not defined.
> it causes a compilation issue:
>
> ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
> 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> | ^~~~~~
>
> So adding PCI_IOV depends to select PCI_ATS.
>
> Signed-off-by: Shixiong Ou <oushixiong@xxxxxxxxxx>
> ---
> drivers/vfio/pci/pds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason