Re: Regression with AX88179A: can't manually set MAC address anymore

From: Sergio Callegari
Date: Thu Sep 07 2023 - 13:50:21 EST


For the time being having AX88179A error out on attempts to set an hardware address would possibly be useful, though.

Sergio

On 06/09/2023 14:31, Andrew Lunn wrote:
So if the in-tree driver could be fixed to correctly support the manual
configuration of the hardware (MAC) address as it used to be that would be
the best. I hope that Andrew Lunn's hypothesis is correct, and that cdc_ncm
can be extended to work with AX88179A even when a manual MAC addr is
configured.
I think it can, but it looks like it needs a different
implementation. The CDC NCM standard is publicly available. It
documents an optional call to set the MAC address, and there appears
to be a capability bit to indicate if its implemented in a specific
device. Ideally if the bit is not set -EOPNOTSUPP should be returned
when trying to set the MAC address, otherwise make the call to let the
hardware know of the new MAC address.

Sorry, i don't have the time or the hardware to actually implement
this. But i can review patches and help with processes.

Andrew