Re: [PATCH v4 3/4] OPP: Add api to retrieve opps which is at most the provided level

[Krishna Chaitanya Chundru]

On 8/23/2023 6:35 AM, Pavan Kondeti wrote:
> On Tue, Aug 22, 2023 at 08:42:20PM +0530, Krishna chaitanya chundru wrote:
> > Add dev_pm_opp_find_level_floor() for searching a lesser match or
> > operating on OPP in the order of decreasing level.
> "OPP: Add api to retrieve opps which is at most the provided level". Pls
> change this to "opp: Add dev_pm_opp_find_level_floor()". The API name
> conveys the message.
>
> In the description, you can give a use case. i.e voting for the max
> level during initialization of a driver.
Done
> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>
> > ---
> >   drivers/opp/core.c     | 26 ++++++++++++++++++++++++++
> >   include/linux/pm_opp.h |  4 ++++
> >   2 files changed, 30 insertions(+)
> >
> > diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> > index 954c948..e668cf2 100644
> > --- a/drivers/opp/core.c
> > +++ b/drivers/opp/core.c
> > @@ -727,6 +727,32 @@ struct dev_pm_opp *dev_pm_opp_find_level_ceil(struct device *dev,
> >   }
> >   EXPORT_SYMBOL_GPL(dev_pm_opp_find_level_ceil);
> >   
> > +
> > +/**
> > + * dev_pm_opp_find_level_floor() - Search for a rounded floor freq
> > + * @dev:	device for which we do this operation
> > + * @freq:	Start level
> > + *
> %s/freq/level
>
> Run make W=1 so that kerneldoc is tested.
Done
> > + * Search for the matching floor *available* OPP from a starting level
> > + * for a device.
> > + *
> > + * Return: matching *opp and refreshes *level accordingly, else returns
> > + * ERR_PTR in case of error and should be handled using IS_ERR. Error return
> > + * values can be:
> What do you mean by refresh here?

Level  argument will be updated by this API with the opp level being 
returned here,

I was trying to use same terminology used in other API's

> > + * EINVAL:	for bad pointer
> > + * ERANGE:	no match found for search
> > + * ENODEV:	if device not found in list of registered devices
> > + *
> > + * The callers are required to call dev_pm_opp_put() for the returned OPP after
> > + * use.
> > + */
> > +struct dev_pm_opp *dev_pm_opp_find_level_floor(struct device *dev,
> > +					      unsigned long *level)
> > +{
> > +	return _find_key_floor(dev, level, 0, true, _read_level, NULL);
> > +}
> > +EXPORT_SYMBOL_GPL(dev_pm_opp_find_level_floor);
> > +
> >   /**
> >    * dev_pm_opp_find_bw_ceil() - Search for a rounded ceil bandwidth
> >    * @dev:	device for which we do this operation
> > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
> > index dc1fb58..a3bc386 100644
> > --- a/include/linux/pm_opp.h
> > +++ b/include/linux/pm_opp.h
> > @@ -128,6 +128,8 @@ struct dev_pm_opp *dev_pm_opp_find_level_exact(struct device *dev,
> >   					       unsigned int level);
> >   struct dev_pm_opp *dev_pm_opp_find_level_ceil(struct device *dev,
> >   					      unsigned int *level);
> > +struct dev_pm_opp *dev_pm_opp_find_level_floor(struct device *dev,
> > +					      unsigned long *level);
> >   
> >   struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev,
> >   					     unsigned long *freq);
> > @@ -285,6 +287,8 @@ static inline struct dev_pm_opp *dev_pm_opp_find_bw_ceil(struct device *dev,
> >   
> >   static inline struct dev_pm_opp *dev_pm_opp_find_bw_floor(struct device *dev,
> >   					unsigned int *bw, int index)
> > +static inline struct dev_pm_opp *dev_pm_opp_find_level_floor(struct device *dev,
> > +					unsigned long *level)
> >   {
> >   	return ERR_PTR(-EOPNOTSUPP);
> >   }
> Please run ./scripts/checkpatch.pl --strict <your patch> and fix the
> indentation warnings from this patch.
>
> Thanks,
> Pavan

Done

- KC