Re: [PATCH v9 1/6] pwm: dwc: split pci out of core driver

[Uwe Kleine-König]

Hello,

On Thu, Sep 07, 2023 at 05:12:37PM +0100, Ben Dooks wrote:
> Moving towards adding non-pci support for the driver, move the pci
> parts out of the core into their own module. This is partly due to
> the module_driver() code only being allowed once in a module and also
> to avoid a number of #ifdef if we build a single file in a system
> without pci support.
> 
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>

Great you continue here even though your commercial interest already
ended!

This series conflicts with my lifetime series[1], but I guess we can
sort that one when at least one of these two series is applied.

[1] https://lore.kernel.org/linux-pwm/20230808171931.944154-1-u.kleine-koenig@xxxxxxxxxxxxxx/

> [...]
> diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> index 3bbb26c862c3..bd9cadb497d7 100644
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * DesignWare PWM Controller driver
> + * DesignWare PWM Controller driver (PCI part)
>   *
>   * Copyright (C) 2018-2020 Intel Corporation
>   *
> @@ -13,6 +13,8 @@
>   *   periods are one or more input clock periods long.
>   */
>  
> +#define DEFAULT_MOUDLE_NAMESPACE dwc_pwm
> +

There is no exported symbol in this driver, so this #define is unused.

>  #include <linux/bitops.h>
>  #include <linux/export.h>
>  #include <linux/kernel.h>

Otherwise looks fine:

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

(with or without dropping DEFAULT_MOUDLE_NAMESPACE from pwm-dwc.c)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature