Re: [PATCH 3/4] perf tests task_analyzer: use perf check for libtraceevent support

[Namhyung Kim]

On Sun, Sep 3, 2023 at 4:47 AM Aditya Gupta <adityag@xxxxxxxxxxxxx> wrote:
>
> Currently we use output of 'perf version --build-options', to check whether
> perf was built with libtraceevent support.
>
> Instead, use 'perf check --feature libtraceevent' to check for
> libtraceevent support.
>
> Signed-off-by: Aditya Gupta <adityag@xxxxxxxxxxxxx>
> ---
>  tools/perf/tests/shell/test_task_analyzer.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
> index 92d15154ba79..8fbc33c95025 100755
> --- a/tools/perf/tests/shell/test_task_analyzer.sh
> +++ b/tools/perf/tests/shell/test_task_analyzer.sh
> @@ -52,8 +52,8 @@ find_str_or_fail() {
>
>  # check if perf is compiled with libtraceevent support
>  skip_no_probe_record_support() {
> -       perf version --build-options | grep -q " OFF .* HAVE_LIBTRACEEVENT" && return 2
> -       return 0
> +       perf check --feature libtraceevent >/dev/null && return 0

Maybe we can add -q/--quiet option to silent messages.

Thanks,
Namhyung


> +       return 2
>  }
>
>  prepare_perf_data() {
> --
> 2.41.0
>