Re: [PATCH -next] scsi: ufs: core: Simplify bool conversion

From: Bart Van Assche
Date: Thu Sep 07 2023 - 18:47:53 EST


On 9/6/23 17:54, Yang Li wrote:
./drivers/ufs/core/ufshcd.c:2307:26-31: WARNING: conversion to bool not needed here

Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2df07545f96..04bbe38ffd87 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -2304,7 +2304,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
500, UIC_CMD_TIMEOUT * 1000, false, hba,
REG_CONTROLLER_STATUS);
- return ret == 0 ? true : false;
+ return ret == 0;
}

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>