RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index corruption.

From: Ratheesh Kannoth
Date: Thu Sep 07 2023 - 22:51:52 EST


> From: Simon Horman <horms@xxxxxxxxxx>
> Subject: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index
> corruption.
> -void cn10k_refill_pool_ptrs(void *dev, struct otx2_cq_queue *cq)
> > +int cn10k_refill_pool_ptrs(void *dev, struct otx2_cq_queue *cq)
> > {
> > struct otx2_nic *pfvf = dev;
> > u64 ptrs[NPA_MAX_BURST];
> > int num_ptrs = 1;
> > dma_addr_t bufptr;
> > + int cnt = cq->pool_ptrs;
>
> nit: please arrange local variables in new Networking code in reverse xmas
> tree order - longest line to shortest.
ACK

-Ratheesh