Re: [PATCH] Revert "printk: export symbols for debug modules"

[Petr Mladek]

On Tue 2023-09-05 15:20:22, Christoph Hellwig wrote:
> On Tue, Sep 05, 2023 at 11:54:37AM +0200, Petr Mladek wrote:
> > Yeah, I did not have a good feeling about this patch.
> > 
> > I accepted it because there was an intention to upstream
> > the module, see
> > https://lore.kernel.org/all/CAAfh-jM0B2Cn579B0CkCrW44pJGGvjs112K+oMuViib+jDKafg@xxxxxxxxxxxxxx/
> > 
> > I think that it was bad decision. We should not export
> > symbols when there is no in-tree user.
> 
> I think raw address to the printk buffer is a bad idea even for an
> in-tree module.

Yeah, I suggested to use the kmsg_dump() API in the original thread.

Sigh, I made the bad decision in a hurry before vacation. I know
that it is a bad excuse but... Thanks for catching it.

Best Regards,
Petr

PS: I have just sent a pull request with the revert.