Re: [PATCH v4 15/17] media: qcom: camss: Move vfe_disable into a common routine where applicable

[Konrad Dybcio]

On 8.09.2023 12:02, Konrad Dybcio wrote:
> On 7.09.2023 18:44, Bryan O'Donoghue wrote:
>> We can move vfe_disable() into a common routine in the core VFE file
>> provided we make wm_stop() a VFE specific callback.
>>
>> The callback is required to capture the case where VFE 17x currently isn't
>> VC enabled where as VFE 480 is.
>>
>> Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>> ---
> Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> 
> Konrad
Actually there's 

ret = vfe_reset(vfe);

return ret;


which could just be

return vfe_reset(vfe);


Konrad