Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y

[Linus Walleij]

Hi Zhizhou,

wow a great patch! I'm surprised no-one has been hit by this before.
I guess we were lucky.

On Thu, Sep 7, 2023 at 4:33 PM Zhizhou Zhang <zhizhou.zh@xxxxxxxxx> wrote:

> From: Zhizhou Zhang <zhizhouzhang@xxxxxxxxxxxx>
>
> flush_cache_all() save registers to stack at function entry.
> If it's called after cache disabled, the data is written to
> memory directly. So the following clean cache operation corrupted
> registers saved by flush_cache_all(), including lr register.
> calling flush_cache_all() before turn off cache fixed the problem.
>
> Signed-off-by: Zhizhou Zhang <zhizhouzhang@xxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I would also add
Cc: stable@xxxxxxxxxxxxxxx

Then please put this into Russell's patch tracker once review
is complete.

Yours,
Linus Walleij