Re: [PATCH 00/52] m68k: W=1 fixes

From: Arnd Bergmann
Date: Sat Sep 09 2023 - 04:38:29 EST


On Thu, Sep 7, 2023, at 15:41, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series addresses the remaining (after [1]) warnings seen when
> building arch/m68k/ with W=1. Perhaps surprisingly, this work has
> identified and fixes a genuine bug in the Sun-3 TLB handling (see [PATCH
> 39/52]).
>
> Most of the patches in these series are fairly trivial changes with a
> very low risk of introducing any regressions. For the less trivial
> patches, I did look at the assembler output before and after. As Arnd
> is working actively on enabling W=1 rather sooner than later, and if no
> one objects, I plan to rebase [1] and this series after the release of
> v6.6-rc1, and send it as a fixes pull request to Linus.
>
> Note that this series does not address warnings on Coldfire or MMU-less
> systems.
>
> Thanks for your comments!
>
> [1] "[PATCH 0/6] m68k: math-emu: Miscellaneous esthetical improvements"
> https://lore.kernel.org/r/cover.1692283195.git.geert@xxxxxxxxxxxxxx

Thanks a lot for doing these, looks all good to me. I sent
two minor comments, but those patches are still ok.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>