Re: [PATCH] Fix typo in tpmrm class definition

[Ivan Orlov]

On 08.09.2023 18:06, Justin M. Forbes wrote:
> Commit d2e8071bed0be ("tpm: make all 'class' structures const")
> unfortunately had a typo for the name on tpmrm.
>
> Fixes: d2e8071bed0b ("tpm: make all 'class' structures const")
> Signed-off-by: Justin M. Forbes <jforbes@xxxxxxxxxxxxxxxxx>
> ---
>   drivers/char/tpm/tpm-chip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 23f6f2eda84c..42b1062e33cd 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -33,7 +33,7 @@ const struct class tpm_class = {
>   	.shutdown_pre = tpm_class_shutdown,
>   };
>   const struct class tpmrm_class = {
> -	.name = "tmprm",
> +	.name = "tpmrm",
>   };
>   dev_t tpm_devt;

Hi Justin,

Thank you for fixing this mistake, it's my bad :(

I'm not sure if you know this or not, but merge window is still opened, 
so the patch could be accidentally skipped by maintainers as they have a 
huge load during this period... Perhaps resending it in a few days might 
be a good idea.

Also, probably adding 'tpm:' prefix to the commit title could make it 
more noticeable to the maintainers.

Thank you again for doing this.

--
Kind regards,
Ivan Orlov