arch/x86/events/intel/pt.c:674: warning: Function parameter or member 'cpu' not described in 'topa_insert_pages'
From: kernel test robot
Date: Sat Sep 09 2023 - 16:18:29 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2a5a4326e58339a26cd1510259e7310b8c0980ff
commit: 90583af61d0c0d2826f42a297a03645b35c49085 perf/x86/intel/pt: Clean up ToPA allocation path
date: 4 years ago
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20230910/202309100419.uLqvM7jh-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230910/202309100419.uLqvM7jh-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309100419.uLqvM7jh-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> arch/x86/events/intel/pt.c:674: warning: Function parameter or member 'cpu' not described in 'topa_insert_pages'
>> arch/x86/events/intel/pt.c:1066: warning: Function parameter or member 'cpu' not described in 'pt_buffer_init_topa'
arch/x86/events/intel/pt.c:1066: warning: Function parameter or member 'nr_pages' not described in 'pt_buffer_init_topa'
arch/x86/events/intel/pt.c:1066: warning: Excess function parameter 'size' description in 'pt_buffer_init_topa'
arch/x86/events/intel/pt.c:1111: warning: Function parameter or member 'event' not described in 'pt_buffer_setup_aux'
arch/x86/events/intel/pt.c:1111: warning: Excess function parameter 'cpu' description in 'pt_buffer_setup_aux'
vim +674 arch/x86/events/intel/pt.c
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 662
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 663 /**
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 664 * topa_insert_pages() - create a list of ToPA tables
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 665 * @buf: PT buffer being initialized.
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 666 * @gfp: Allocation flags.
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 667 *
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 668 * This initializes a list of ToPA tables with entries from
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 669 * the data_pages provided by rb_alloc_aux().
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 670 *
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 671 * Return: 0 on success or error code.
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 672 */
90583af61d0c0d arch/x86/events/intel/pt.c Alexander Shishkin 2019-08-21 673 static int topa_insert_pages(struct pt_buffer *buf, int cpu, gfp_t gfp)
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 @674 {
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 675 struct topa *topa = buf->last;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 676 int order = 0;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 677 struct page *p;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 678
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 679 p = virt_to_page(buf->data_pages[buf->nr_pages]);
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 680 if (PagePrivate(p))
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 681 order = page_private(p);
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 682
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 683 if (topa_table_full(topa)) {
90583af61d0c0d arch/x86/events/intel/pt.c Alexander Shishkin 2019-08-21 684 topa = topa_alloc(cpu, gfp);
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 685 if (!topa)
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 686 return -ENOMEM;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 687
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 688 topa_insert_table(buf, topa);
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 689 }
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 690
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 691 TOPA_ENTRY(topa, -1)->base = page_to_phys(p) >> TOPA_SHIFT;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 692 TOPA_ENTRY(topa, -1)->size = order;
f6d079ce867d67 arch/x86/events/intel/pt.c Chao Peng 2018-10-24 693 if (!buf->snapshot &&
f6d079ce867d67 arch/x86/events/intel/pt.c Chao Peng 2018-10-24 694 !intel_pt_validate_hw_cap(PT_CAP_topa_multiple_entries)) {
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 695 TOPA_ENTRY(topa, -1)->intr = 1;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 696 TOPA_ENTRY(topa, -1)->stop = 1;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 697 }
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 698
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 699 topa->last++;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 700 topa->size += sizes(order);
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 701
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 702 buf->nr_pages += 1ul << order;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 703
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 704 return 0;
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 705 }
52ca9ced3f7077 arch/x86/kernel/cpu/perf_event_intel_pt.c Alexander Shishkin 2015-01-30 706
:::::: The code at line 674 was first introduced by commit
:::::: 52ca9ced3f70779589e6ecc329baffe69d8f5f7a perf/x86/intel/pt: Add Intel PT PMU driver
:::::: TO: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
:::::: CC: Ingo Molnar <mingo@xxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki