fs/smb/server/vfs.c:929: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_setxattr'

From: kernel test robot
Date: Sun Sep 10 2023 - 21:34:30 EST

Next message: kernel test robot: "include/linux/vfio.h:294:35: error: weak declaration of 'vfio_file_iommu_group' being applied to a already existing, static definition"
Previous message: Tengfei Fan: "Re: [PATCH 2/3] pinctrl: qcom: Add SM4450 pinctrl driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
commit: 40b268d384a22276dca1450549f53eed60e21deb ksmbd: add mnt_want_write to ksmbd vfs functions
date: 3 months ago
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230911/202309110946.zgwPz5cN-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230911/202309110946.zgwPz5cN-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309110946.zgwPz5cN-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

fs/smb/server/vfs.c:54: warning: Function parameter or member 'parent' not described in 'ksmbd_vfs_lock_parent'
fs/smb/server/vfs.c:54: warning: Function parameter or member 'child' not described in 'ksmbd_vfs_lock_parent'
fs/smb/server/vfs.c:372: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_read'
fs/smb/server/vfs.c:372: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_read'
fs/smb/server/vfs.c:488: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_write'
fs/smb/server/vfs.c:488: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_write'
fs/smb/server/vfs.c:551: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:551: warning: Function parameter or member 'stat' not described in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:551: warning: Excess function parameter 'work' description in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:551: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:551: warning: Excess function parameter 'attrs' description in 'ksmbd_vfs_getattr'
fs/smb/server/vfs.c:568: warning: Function parameter or member 'p_id' not described in 'ksmbd_vfs_fsync'
fs/smb/server/vfs.c:591: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_remove_file'
fs/smb/server/vfs.c:591: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_remove_file'
fs/smb/server/vfs.c:591: warning: Excess function parameter 'name' description in 'ksmbd_vfs_remove_file'
fs/smb/server/vfs.c:634: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_link'
fs/smb/server/vfs.c:811: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_truncate'
fs/smb/server/vfs.c:811: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_truncate'
fs/smb/server/vfs.c:852: warning: Excess function parameter 'size' description in 'ksmbd_vfs_listxattr'
>> fs/smb/server/vfs.c:929: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_setxattr'
>> fs/smb/server/vfs.c:929: warning: Excess function parameter 'dentry' description in 'ksmbd_vfs_setxattr'
fs/smb/server/vfs.c:954: warning: Function parameter or member 'option' not described in 'ksmbd_vfs_set_fadvise'
fs/smb/server/vfs.c:954: warning: Excess function parameter 'options' description in 'ksmbd_vfs_set_fadvise'
fs/smb/server/vfs.c:1168: warning: Function parameter or member 'um' not described in 'ksmbd_vfs_lookup_in_dir'
fs/smb/server/vfs.c:1203: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_kern_path_locked'

vim +929 fs/smb/server/vfs.c

f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 914
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 915 /**
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 916 * ksmbd_vfs_setxattr() - vfs helper for smb set extended attributes value
4609e1f18e19c3 fs/ksmbd/vfs.c Christian Brauner 2023-01-13 917 * @idmap: idmap of the relevant mount
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 918 * @dentry: dentry to set XATTR at
63f09a9986eb58 fs/ksmbd/vfs.c Jiapeng Chong 2023-02-08 919 * @attr_name: xattr name for setxattr
63f09a9986eb58 fs/ksmbd/vfs.c Jiapeng Chong 2023-02-08 920 * @attr_value: xattr value to set
63f09a9986eb58 fs/ksmbd/vfs.c Jiapeng Chong 2023-02-08 921 * @attr_size: size of xattr value
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 922 * @flags: destination buffer length
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 923 *
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 924 * Return: 0 on success, otherwise error
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 925 */
4609e1f18e19c3 fs/ksmbd/vfs.c Christian Brauner 2023-01-13 926 int ksmbd_vfs_setxattr(struct mnt_idmap *idmap,
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 927 const struct path *path, const char *attr_name,
0c5fd887d2bb47 fs/ksmbd/vfs.c Christian Brauner 2022-07-06 928 void *attr_value, size_t attr_size, int flags)
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 @929 {
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 930 int err;
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 931
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 932 err = mnt_want_write(path->mnt);
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 933 if (err)
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 934 return err;
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 935
4609e1f18e19c3 fs/ksmbd/vfs.c Christian Brauner 2023-01-13 936 err = vfs_setxattr(idmap,
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 937 path->dentry,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 938 attr_name,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 939 attr_value,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 940 attr_size,
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 941 flags);
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 942 if (err)
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 943 ksmbd_debug(VFS, "setxattr failed, err %d\n", err);
40b268d384a222 fs/smb/server/vfs.c Namjae Jeon 2023-06-15 944 mnt_drop_write(path->mnt);
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 945 return err;
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 946 }
f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 947

:::::: The code at line 929 was first introduced by commit
:::::: f44158485826c076335d6860d35872271a83791d cifsd: add file operations

:::::: TO: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
:::::: CC: Steve French <stfrench@xxxxxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Next message: kernel test robot: "include/linux/vfio.h:294:35: error: weak declaration of 'vfio_file_iommu_group' being applied to a already existing, static definition"
Previous message: Tengfei Fan: "Re: [PATCH 2/3] pinctrl: qcom: Add SM4450 pinctrl driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]