Re: [PATCH 01/15] soc: mediatek: Add register definitions for GCE

[Shawn Sung (宋孝謙)]

Hi Angelo,

On Thu, 2023-09-07 at 14:11 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/08/23 17:13, Hsiao Chien Sung ha scritto:
> > Add register definitions for GCE so users can use them
> > as a buffer to store data.
> > 
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx>
> > ---
> >   include/linux/soc/mediatek/mtk-cmdq.h | 7 +++++++
> >   1 file changed, 7 insertions(+)
> > 
> > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h
> > b/include/linux/soc/mediatek/mtk-cmdq.h
> > index 649955d2cf5c..3eb95ef34c6c 100644
> > --- a/include/linux/soc/mediatek/mtk-cmdq.h
> > +++ b/include/linux/soc/mediatek/mtk-cmdq.h
> > @@ -14,6 +14,13 @@
> >   #define CMDQ_ADDR_HIGH(addr)	((u32)(((addr) >> 16) &
> > GENMASK(31, 0)))
> >   #define CMDQ_ADDR_LOW(addr)	((u16)(addr) | BIT(1))
> >   
> 
> Please add a comment explaining "TPR"

It means Time Purpose Register. Will remove it in the new version since
it is not being used.

> 
> > +#define CMDQ_TPR_ID		(56)
> > +
> 
> Please add a comment explaining what those definitions are, what is
> "SPR"?

SPR is Specific Purpose Registers. Will add a comment in the next
version.

Thanks,
Hsiao Chien Sung