Re: [PATCH V2 4/6] pinctrl: sprd: Add pinctrl support for UMS512

From: Andy Shevchenko
Date: Mon Sep 11 2023 - 17:04:27 EST


On Fri, Sep 08, 2023 at 01:51:44PM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@xxxxxxxxxx>
>
> Add the pin control driver for UNISOC UMS512 platform.

...

> +#define PINCTRL_REG_OFFSET 0x34

0x0034

> +#define PINCTRL_REG_MISC_OFFSET 0x434

...

> +static const struct of_device_id sprd_pinctrl_of_match[] = {
> + { .compatible = "sprd,ums512-pinctrl", },

Inner comma is not needed.

> + { }
> +};

--
With Best Regards,
Andy Shevchenko