Re: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity

From: Conor Dooley
Date: Mon Sep 11 2023 - 17:19:28 EST


On Mon, Sep 11, 2023 at 05:03:07PM +0200, Nicolas Ferre wrote:
> On 01/08/2023 at 17:35, Conor Dooley wrote:
> > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > > index dfb8fd089197..89d75fbb1de4 100644
> > > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > > @@ -79,6 +79,13 @@ properties:
> > > - const: atmel,sama5d2
> > > - const: atmel,sama5
> > > + - description: Microchip SAMA5D29 Curiosity
> > > + items:
> > > + - const: microchip,sama5d29-curiosity
> > > + - const: atmel,sama5d29
> > > + - const: atmel,sama5d2
> > > + - const: atmel,sama5
> > What is the benefit of adding the two familial compatibles? Is there
> > software that actually uses these?
>
> "atmel,sama5d2" is used by arch/arm/mach-at91/sama5.c file
> "atmel,sama5" is used by drivers/soc/atmel/soc.c file, so yes they are
> needed to instantiate a sama5d29 SoC.

Okay.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature