Re: [PATCH v5 12/32] sound: usb: Export USB SND APIs for modules

[Wesley Cheng]

Hi Takashi,

On 9/7/2023 8:38 AM, Takashi Iwai wrote:
> On Tue, 29 Aug 2023 23:06:37 +0200,
> Wesley Cheng wrote:
> > -/*
> > - * hw_params callback
> > - *
> > - * allocate a buffer and set the given audio format.
> > - *
> > - * so far we use a physically linear buffer although packetize transfer
> > - * doesn't need a continuous area.
> > - * if sg buffer is supported on the later version of alsa, we'll follow
> > - * that.
> > - */
> > -static int snd_usb_hw_params(struct snd_pcm_substream *substream,
> > -			     struct snd_pcm_hw_params *hw_params)
> > +int snd_usb_attach_endpoints(struct snd_usb_substream *subs,
> > +				struct snd_pcm_hw_params *hw_params)
>
> This doesn't only "attach" endpoints, but it does more other things
> that are needed for PCM hw_params procedure.  I'd rather keep
> hw_params in the function name instead of creating completely
> different one.
>
> Ditto for hw_free.

Sure I'll keep the same nomenclature as it was previously.

Thanks
Wesley Cheng