Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings

From: Thomas Weißschuh
Date: Mon Sep 11 2023 - 17:28:29 EST


On 2023-09-11 16:30:25+0200, Willy Tarreau wrote:
> On Mon, Sep 11, 2023 at 04:26:41PM +0200, Thomas Weißschuh wrote:
> > On 2023-09-11 08:04:49+0200, Willy Tarreau wrote:
> > > On Sun, Sep 10, 2023 at 09:29:01PM +0200, Thomas Weißschuh wrote:
> > > > Newer versions of glibc annotate the poll() function with
> > > > __attribute__(access) which triggers a compiler warning inside the
> > > > testcase poll_fault.
> > > > Avoid this by using a plain NULL which is enough for the testcase.
> > > > To avoid potential future warnings also adapt the other EFAULT
> > > > testcases, except select_fault as NULL is a valid value for its
> > > > argument.
> > > (...)
> > >
> > > Looks good to me. I wouldn't be surprised if we're soon forced to do
> > > the same with select() on some archs where it might be emulated.
> > >
> > > Feel free to push it to the shared repo.
> >
> > Thanks, I pushed it to the "next" branch.
> >
> > I'd also like to rebase the next branch onto v6.6-rc1, any objections?
>
> Yes, please go on!

Done.

I used "git rebase --signoff" and dropped the duplicate signoffs it
generated on my own commits.

It's also pushed to git.kernel.org, could you double-check it?

Thanks,
Thomas