Re: [PATCH 5/5] arm64: dts: meson: u200: add onboard devices

[Neil Armstrong]

On 11/09/2023 17:56, Krzysztof Kozlowski wrote:
> On 11/09/2023 17:45, Jerome Brunet wrote:
> > Add missing audio devices found on the u200 PCB. This includes
> > * Lineout connected to the internal DAC
> > * SPDIF input connected to a coaxial socket
> > * TDM input decoders allowing output loopback
> > * TDM A and B output encoders and interfaces
> >
> > TDM A and B link format is set by the related external codec.
> > Internal audio DAC can hook to any TDM output.
> >
> > This change does not include support necessary the optional the speaker and
> > PDM Mic headers
> >
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> > ---
> >   .../boot/dts/amlogic/meson-g12a-u200.dts      | 228 +++++++++++++++++-
> >   1 file changed, 218 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
> > index da66e2e1dffb..9abe37b5b227 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
> > @@ -9,6 +9,7 @@
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <dt-bindings/gpio/meson-g12a-gpio.h>
> >   #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
> > +#include <dt-bindings/sound/meson-g12a-toacodec.h>
> >   
> >   / {
> >   	compatible = "amlogic,u200", "amlogic,g12a";
> > @@ -19,6 +20,22 @@ aliases {
> >   		ethernet0 = &ethmac;
> >   	};
> >   
> > +	dioo2133: audio-amplifier-0 {
> > +		#sound-dai-cells = <0>;
> > +		compatible = "simple-audio-amplifier";
>
> compatible is by convention first property. Do you have different style
> in Amlogic/Meson?

Not really, no specific style

> > +		status = "okay";
>
> status is by default.

I'll fix the patch on my tree.

Thanks,
Neil

> Best regards,
> Krzysztof